Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: sig controller-runtime grace period testing #620

Closed
wants to merge 10 commits into from
Closed

WIP: sig controller-runtime grace period testing #620

wants to merge 10 commits into from

Conversation

michaelgugino
Copy link
Contributor

Do not merge

/hold

JoelSpeed and others added 10 commits June 18, 2020 14:46
@JoelSpeed
Switch Machine validation to not require validation/defaulting handlers
453a5b0
@JoelSpeed
Add MachineSet defaulting and validating webhook
05bd80c
@JoelSpeed
Add tests for Machine/MachineSet creation/update via envtest
c754eb5
@JoelSpeed
Switch handlers to wrap admissionHandler
8f538d7
@JoelSpeed
Ensure nil value is handled in machine webhooks
0b72504
@JoelSpeed
Don't create infra object, pass information directly
09af451
@JoelSpeed
Wait for manager to stop before ending test
b6f8df1
@JoelSpeed
Start manager after registering hooks and wait for webhook server bef…
df071c2 
…ore running tests
@michaelgugino
Add MachineSet ControlPlane webhooks
f5a6e42 
Add webhooks for Delete and Update operations
on MachineSets that are identified to be
Control Plane members.  These webhooks prevent
deleting these MachineSets or updating them
to become non-CP MachineSets (in order to
further prevent them from being deleted or
misconfigured)
@michaelgugino
graceperiod testing
0928844
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign michaelgugino
You can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@michaelgugino: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/goimports 0928844 link /test goimports
ci/prow/e2e-aws-operator 0928844 link /test e2e-aws-operator
ci/prow/e2e-gcp-operator 0928844 link /test e2e-gcp-operator
ci/prow/e2e-aws-scaleup-rhel7 0928844 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure-operator 0928844 link /test e2e-azure-operator
ci/prow/e2e-aws-upgrade 0928844 link /test e2e-aws-upgrade
ci/prow/e2e-azure 0928844 link /test e2e-azure
ci/prow/e2e-aws 0928844 link /test e2e-aws
ci/prow/e2e-gcp 0928844 link /test e2e-gcp
ci/prow/govet 0928844 link /test govet
ci/prow/images 0928844 link /test images
ci/prow/unit 0928844 link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelgugino
michaelgugino commented Jun 21, 2020
View reviewed changes
pkg/apis/machine/v1beta1/machineset_webhook_test.go
},
}

for _, tc := range testCases {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test that fails most often without this patch. With this patch, the tests run indefinitely until they hit the 10 minute testing timeout panic built into golang.

@openshift-ci-robot
Copy link
Contributor

@michaelgugino: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelgugino @openshift-ci-robot @JoelSpeed